@microsoft-github-policy-service agree

I see you refactored the code a bit, but I'm trying to see the functional difference. What was wrong before?

If there's a bug here, I want to fix it in my DeviceResources implementation as well. See directx-vs-templates.

I see you refactored the code a bit, but I'm trying to see the functional difference. What was wrong before?

If there's a bug here, I want to fix it in my DeviceResources implementation as well. See directx-vs-templates.

Whitespace changes from a new level of indentation make it harder to see the change: Instead of only checking the default adapter (ThrowIfFailed(m_dxgiFactory->EnumAdapters1(0, &dxgiAdapter));), this PR changes it to iterate through all adapters (while (m_dxgiFactory->EnumAdapters1(adapterI, &dxgiAdapter) == S_OK) {)

Specific instructions on how to reproduce the issue are found in #921

Thanks. Note that != ERROR_NOT_FOUND is problematic for a number of reasons. Try making it:

while (SUCCEEDED(m_dxgiFactory->EnumAdapters1(adapterI, &dxgiAdapter)) {

Thanks. Note that != ERROR_NOT_FOUND is problematic for a number of reasons. Try making it:

while (SUCCEEDED(m_dxgiFactory->EnumAdapters1(adapterI, &dxgiAdapter)) {

Sure. I've currently got it as == S_OK, but I'll switch it over to use the SUCCEEDED convention.